Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Coming Soon page using HTML, CSS and JS

Hoophelieβ€’ 110

@HOOPhelie

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey, everybody! πŸ‘‹

My solution is definitely not pixel perfect, but I tried to make it look pretty on both mobile and desktop! (I'll make the pixel perfect version very soon) It seems to work ok, I'm just not sure of the cleanliness of my code... Any feedback would be much appreciated!

Thank you and happy codingπŸ€—

Community feedback

@Rabin92

Posted

Hey, Hoophelie! πŸ‘‹

You have done a great job on this challenge! πŸ™Œ

The site is fully responsive and looks great on all screen devices. Nicely formatted code with semantic tags in use.

There's just a minor issue with an overlay as it does not fully expand to viewport size on a small screen landscape mode. To fix this issue, you can follow these steps:

Add this code to the body tag:

body {
position: relative;
}

Remove width & height property from .overlay class and add the following code instead:

.overlay {
top: 0;
right: 0;
bottom: 0;
left: 0;
}

And lastly remove height property from a small screen devices with the class name of .landscape-page and add it to the media queries for a medium-large screens.

To fix the accessibility issues, you can simply add a label tag. Learn more about these tag here: https://www.w3schools.com/tags/tag_label.asp

Hope this helps and Happy Coding! 😊

3

Hoophelieβ€’ 110

@HOOPhelie

Posted

Hi @Rabin92 !

  • Sorry for the late answer, and thank you so much for your review!πŸ€— I corrected my code for the overlay!
  • I didn't quite get the part for " remove height property from a small screen devices with the class name of .landscape-page and add it to the media queries for a medium-large screens."... Could you explain what it does?
  • Should I create another media query or are you refering to the "@media screen and (max-width: 80rem) and (min-width: 50rem)" being for medium-large screens?
0
P
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

Hey there, Hoophelie! πŸ‘‹

Nice to see you complete another challenge! πŸ˜€ Nice job on this one! πŸ‘

One more tiny thing I might suggest in addition to Rabin92's helpful feedback is to perhaps add overflow-x: hidden to the body to prevent a horizontal scroll bar from appearing along the bottom of the screen in the mobile layout (or set the width of the image in the mobile layout to 100%, since the image is the element that's overflowing the body and causing this issue, and adding that seems to solve it). πŸ˜‰

Keep coding (and happy coding, too)! 😁

1

Hoophelieβ€’ 110

@HOOPhelie

Posted

Hi, @ApplePieGiraffe ! Nice to see you again, and thank you for your review! I set the width of the image to 100%😁

Happy Coding!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord