@Rabin92
Posted
Hey, Hoophelie! π
You have done a great job on this challenge! π
The site is fully responsive and looks great on all screen devices. Nicely formatted code with semantic tags in use.
There's just a minor issue with an overlay as it does not fully expand to viewport size on a small screen landscape mode. To fix this issue, you can follow these steps:
Add this code to the body tag:
body {
position: relative;
}
Remove width & height property from .overlay
class and add the following code instead:
.overlay {
top: 0;
right: 0;
bottom: 0;
left: 0;
}
And lastly remove height
property from a small screen devices with the class name of .landscape-page
and add it to the media queries for a medium-large
screens.
To fix the accessibility issues, you can simply add a label tag
. Learn more about these tag here: https://www.w3schools.com/tags/tag_label.asp
Hope this helps and Happy Coding! π
@HOOPhelie
Posted
Hi @Rabin92 !
- Sorry for the late answer, and thank you so much for your review!π€ I corrected my code for the overlay!
- I didn't quite get the part for " remove height property from a small screen devices with the class name of .landscape-page and add it to the media queries for a medium-large screens."... Could you explain what it does?
- Should I create another media query or are you refering to the "@media screen and (max-width: 80rem) and (min-width: 50rem)" being for medium-large screens?