Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive coming soon w/ vanilla js

@sqirum

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey guys, Another exercise, using simple css and vanilla js. Any tips or advices are welcome. Happy coding!!

Community feedback

bunee 2,060

@buneeIsSlo

Posted

Hey! @sqirum, Good job on completing this challenge. I have a couple of suggestions for you...

  1. The email submit button is missing focus styles. This is an important thing to add as this helps keyboard users navigate the site.

  2. The method you've currently used to set the hero image works fine, but using a <picture> tag would be much more appropriate. This will also improve the responsiveness of your site.

  3. Speaking of responsiveness, consider using a mobile-first approach when building a site. Watch this video to learn about the advantages of the mobile-first approach.

Hope this helps :)

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord