Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 3 months ago

Responsive component signup with semantic html and css grid w/ the dom

DMVDEV•230
@thedmvdevaustin
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

The time it took me to do this. I timed myself at 3 hours. Which was alot faster than I thought. I'm going to make a check list that I can go through when I finish a project so I make sure I don't forget anything

What specific areas of your project would you like help with?

Semantic html and other validation solutions

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Andrey•4,580
    @dar-ju
    Posted 3 months ago

    Hi!

    Great job! The code is well structured and easy to read, you use the correct font formats (rarely anyone does this here). The semantic structure is correct. It's right that you measure the time spent, it's useful. You are great!

    There are very few things that can be fixed:

    • there is a small error in the html code, an extra href </a href="#">
    • if the form is successfully submitted, you can clear the fields at a minimum, ideally some kind of message
    • you can leave the error alt for the icons empty, because you don't need search engines to index these images. They are not content.
    • you can limit the use of grid - this is more for blocks consisting of 2x2 or more elements. This is not an error, it can just be misleading - you expect to see a real grid, but there is only 1 element inside. Look at flex.
    • look at the layout in a screen resolution of about 760px. You have quite a lot of empty space on the sides of the content. You can expand the content to make it easier to use.

    Otherwise, everything is cool, good luck with your developments!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub