Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Responsive, CSS animation, Render conditional images

react, tailwind-css, typescript, vite
German Pinto•320
@germanp007
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi there

  • In this challenge, I combined useState and useEffect to dynamically render SVGs based on the screen width.
  • I added transitions for the accordion's expansion.
  • The entire styling was done using Tailwind CSS along with some parts in pure CSS.

Feel free to review the code and the project, and please provide feedback if you want (☞゚ヮ゚)☞(☞゚ヮ゚)☞(☞゚ヮ゚)☞

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Petrit Nuredini•2,860
    @petritnuredini
    Posted over 1 year ago

    Congratulations on finishing your project! It's great to see your progress and commitment to building a functional and visually appealing application. Here are a few best practices and recommendations to enhance your work:

    1. Code Organization:

      • Component Structure: Good job breaking down the UI into reusable components. Consider further modularization for complex components for better maintainability.
      • Separation of Concerns: Keep styling, logic, and structure separate. Using CSS modules or styled-components can help achieve this.
    2. Performance:

      • Optimize Image Loading: If you're using images, consider lazy loading or using optimized formats like WebP for better performance.
      • UseEffect Dependency Array: Be cautious with your dependency arrays in useEffect. For instance, widthScreen in your resize effect might cause unnecessary rerenders.
    3. Responsive Design:

      • Media Queries: Good use of media queries for responsiveness. Test across different devices to ensure UI consistency.
      • SVG Responsiveness: Ensure that your SVGs are responsive and render well on all screen sizes.
    4. Accessibility:

      • Semantic HTML: Use semantic HTML tags where appropriate for better accessibility.
      • Keyboard Navigation: Ensure that all interactive elements are accessible through keyboard navigation.
    5. Styling:

      • Consistent Theming: Utilize CSS variables or a theme provider for consistent styling across your app.
      • Avoid Inline Styles: Inline styles can be hard to override and maintain. Consider using external stylesheets or styled components.
    6. Further Learning Resources:

      • For React best practices: React Official Documentation
      • For CSS and styling: Styled Components
      • For performance optimization: Web.Dev

    Keep up the hard work and continue to challenge yourself with new projects! Each project is a stepping stone in your development journey. Stay curious and keep experimenting with new technologies and techniques. Looking forward to seeing your future projects!

    Marked as helpful
  • Codster dev•170
    @codster15
    Posted over 1 year ago

    great ... now try to learn grid and flex to centre the content

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub