Submitted about 3 years ago

Responsive css changes. Note use of rem in font size

@DavidBurgess1984

A solution to the Product preview card component challenge

Solution retrospective

Hi, thanks for looking - I'm looking for feedback on my solution. I want to know if my use of rem as the font sizing is a good approach. I have hardcoded a lot of other sizes in px, but I have read on various sites it is a good idea to use em for spacing like paddings and margins.

How is the use of HTML? I wasn't too sure about whether to use <section> elements instead of <div>.

In general, I'd like some feedback or any suggestions for improvements. I want to try and get better at styling sites in css.

Code

Please log in to post a comment

Community feedback

No feedback yet. Be the first to give feedback on David Burgess's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord