Responsive CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PARAGRAPHS ⚠️:

  • This solution consists incorrect usage of <p> so it can cause severe accessibility errors due to incorrect usage of paragraph element <p>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <p> element which is this <p>Improve your...</p>, you can preferably use <h1> instead of <p>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  01

  Marked as helpful
• 

  khushboo khatwani•1,070

  @khushi0909

  Posted about 2 years ago

  1)Read about h1 tag its the most important and every website should have atleast one https://www.semrush.com/blog/h1-tag/

  2)you should learn about semantics HTML and using it for ex footer ,main etc

  3)image should always have alt="some description". some description about image should always be there for accessibility reasons

  https://www.davidmacd.com/blog/alternate-text-for-css-background-images.html

  4)i feel something wrong with the positioning of the background image or color you have used ,its creating some problem in responsiveness view for different screen and you are getting lot of scroll bar both vertically and horizontally ,it should not be ideally as per design like this

  5)i personally feel using flexbox in the body tag will also be better' and mentioning in body min-height as 100vh may help (read about min-height 100vh more)

  All the best

  01

  Marked as helpful