@pikapikamart
Posted
Hey, awesome work on this one. Site in general looks great and it is responsive as well.
argel omnes already gave great feedback on this one, just going to add some suggestions as well:
- Don't use
height: 100%
on thehtml
andbody
as they are relative to the viewport which caps their height. Use alwaysmin-height: 100vh
. - On the
body
tag, your image-path on thebackground
is wrong. Use this insteadurl("../images/pattern-background-desktop.svg")
- Instead of using
role="main"
on the.content
selector, just simply usemain
tag instead ofdiv
. - The illustration is on a decorative image. Decorative images should be hidden for screen-reader at all times by using
alt=""
andaria-hidden="true"
to theimg
tag or onlyaria-hidden="true"
if the image is usingsvg
. - The music-icon as well is only decoration so hide it using method above.
annual plan
could use a heading tag since it gives overview on what the section would contain. Anh2
would be great.- Do not remove the
outline
styling. If you did, always include a visual-indicator on the:focus-visible
for those interactive elements like thebutton
a
tag and others.
Aside from those, great job again on this one.
Marked as helpful
@wickedWango
Posted
@pikamart Hey Raymart, Thanks for taking your time to review my code. These points are awesome.
I was not aware of the fact that we should hide the svgs for screen reader.
I forgot to update the changes in css image paths as I moved those files into a css folder moments ago.
I will keep these points in mind. Thanks for the detailed explanation about them.
As I am new to this CSS world, I am figuring out all the good design practices. I am feeling that I have learnt new things from your feedback.
Edit :- I have changed the code based on your feedback.