Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

Responsive design with grid and flexbox

Alejandro Cañon•260
@alecanonm
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I did this challenge again putting in practice the concepts in the last feedback, i've been studying so hard lastly so i'm here to give all of me.

I made this little challenge using pure css and applying my best practices.

I would love to receive more feedback to keep improving my skills and learn from you guys!

greeting! 😃🚀

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • gfunk77•1,270
    @gfunk77
    Posted almost 2 years ago

    Well done Alejandro. Your solution looks just like the picture so it is totally excellent.

    I would suggest experimenting with something like this:

    <main class="container"> <div class="wrapper"> <img src="./images/image-qr-code.png" alt="QR code" /> <h1>Improve your front-end skills by building projects</h1> <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level </p> </div> </main>

    All I did above was put the img, h1, and p inside the wrapper. From here, you could just put a padding all the way around on the .container. Put border: 2px solid color on the boxes so you can see what is happening and what is taking up space. Then I'll think you'll find that you wont need to put widths on the h1 and p. You won't even need the flexbox on the container. This might help streamline your css.

    I hope this is helpful feedback. Great work!!

    Marked as helpful
  • Jewlius X•30
    @jewlias
    Posted almost 2 years ago

    Great work Alejandro on completing the QR code challenge

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub