@vanzasetia
Posted
Hi there! 👋
Your solution is responsive and looks great! 👍
Some suggestions from me.
- Avoid using
header
andarticle
for the card content since it is not a complete website. This is one chunk of content that all belong together and in a real website would sit with other content. So, I recommend wrapping each section withdiv
instead. - For the "Why us" section, I would recommend making it as a list of items instead of using paragraph elements. If the site has no styling then it would more likely be a list.
- I don't recommend changing the
html
or the:root
font size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements. I suggest reading this article by Josh Comeau where he tells about the problem of the 62.5% trick (and more!). Also, I recommend reading what an accessibility expert (Grace Snow) has said about it.
That's it! Hope this helps. 😊
@vikramvi
Posted
@vanzasetia Thanks a ton for review and comments, I'll read more about them and fix it.
Regards, Vikram
@vanzasetia
Posted
@vikramvi No problem! 👍