@pikapikamart
Posted
Hey, awesome work on this one. Desktop layout is wider than the design, the responsive state could be better since the hero-section's img
is really big when it transitioned to mobile state. On mobile state, the text needs to centered and some padding on the bottom would be great.
Gregg Christofferson already gave a great suggestion on this one, just going to add some as well:
- Avoid using
height: 100vh
on a large container like thebody
tag, as this limits the element's height based on the remaining screen's height. Usemin-height: 100vh
instead, this takes full height but lets the element expand if needed. - Always have a
main
element to wrap the main content of your site. On this one,.container
should be usingmain
instead ofdiv
. - Always have a single
h1
on a page, on this one, the.header
should be usingh1
instead ofdiv
. - When wrapping text-content, wrap them in meaningful element like heading tag,
p
tag or other and not justdiv
. Thosediv
that you used to wrap the text-content should be replaced withp
tag if it is just a regular text. - The
.stats
could use aul
element since those are "list" of information about the company website. - The
img
alt
could be better since you are making it visible. Using onlyalt="image-header"
does not give any extra information at all about what the image looks like right. So better to make it descriptive :> - Lastly, just the responsive state should be looked at.
Aside from those, great work again on this one.
Marked as helpful