Responsive dropdown navigation menu using html, sass and js

Community feedback

• 

  Petrit Nuredini•2,860

  @petritnuredini

  Posted over 1 year ago

  Congratulations on completing the Frontend Mentor challenge! Your project showcases dedication and skill. Here are a few suggestions to enhance your work:

  1. Responsive Meta Tag:

     • The viewport meta tag currently set as <meta name="viewport" content="width=device-width, initial-scale=1.0"> is excellent for responsive design. Ensure it's consistently used across your projects for optimal responsiveness on different devices.

  2. JavaScript Event Handling:

     • Your use of onclick directly in HTML elements like <a href="#" onclick="myFunction(event)" class="dropbtn"> can be improved. Instead, consider attaching event listeners in your JavaScript file. This approach separates structure (HTML) from behavior (JavaScript), making the code more maintainable and scalable.

  3. Optimizing CSS:

     • In your CSS, you've done a great job organizing styles. To further enhance readability and maintenance, consider grouping related styles together (e.g., all button styles in one place) and using comments to delineate sections.

  Resources for Further Learning:

  • Responsive Design Best Practices: MDN Web Docs on Responsive Design
  • JavaScript Event Listeners: JavaScript.info - Introduction to Browser Events
  • CSS Organization Techniques: CSS-Tricks - Organizing CSS

  Keep pushing the boundaries of your coding skills. Every challenge you overcome builds your competence and confidence as a developer. Keep coding and exploring new frontiers! 🚀👨‍💻

  11
• 

  Alok Suman•2,360

  @Alokray007

  Posted over 1 year ago

  Hello there 👋 @hilla10

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  I hope this suggestion is useful for future projects.

  Other than that, great job!

  Happy coding.

  01