Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 12 months ago

Responsive e-commerce product page using CSS Flex, Grid, JS

Anton Vasilache•580
@Antonvasilache
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?
  • I did this without the use of a JS framework, even though a framework would have been faster I think.
  • I've done the thumbnail navigation, and then adapted it for the lightbox, and then for the smaller screens.
  • Would probably give more though to the css sizes, and try to use rem instead of px where it makes sense.
What challenges did you encounter, and how did you overcome them?
  • Creating the thumbnail navigation for the lightbox - did it using data attributes and some DOM traversing.
  • Refactoring the thumbnails navigation to work both inside the lightbox and on the smaller screens - it worked with passing the parent container as a parameter to the navigateThumbnails function and adding some optional chaining.
  • Adapting the active state for mobile, especially the shopping cart position - did it by using absolute positioning and some translation.
What specific areas of your project would you like help with?

Maybe there is a better way of refactoring the functions and handling the responsiveness.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Krushna Sinnarkar•1,080
    @krushnasinnarkar
    Posted 12 months ago

    Hi @Antonvasilache,

    Congratulations on successfully completing the challenge!

    I have suggestions regarding your code that I believe will be of great interest to you.

    1. Container Positioning: I noticed that your container is not positioned properly after a screen size of 1210px. This is mostly due to the padding you've added to the body. If you remove it, the problem should be resolved.

    2. Media Queries Optimization: You are using too many media queries for small adjustments. Try to use fewer media queries by combining them. For example, you can make the .nav hidden at the same time you make the main section vertical. Avoid adding multiple media queries for minor changes.

    3. Overlay Close-Icon Position: Your overlay looks perfect in inspect mode, but on a normal screen, the close icon is out of view. This is mostly due to the inline CSS added to the image:

      /* width: 100%; */
      /* max-width: 550px; */
      /* height: 100%; */
      /* max-height: 550px; */
      

      If you remove these properties, it should work fine. Also, you need to position the arrows properly after making these changes.

    I hope you find this helpful, and I would greatly appreciate it if you could mark my comment as helpful if it was.

    Feel free to reach out if you have more questions or need further assistance.

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub