Responsive Ecommerce-product-page using React

Community feedback

• 

  Andrey•4,710

  @dar-ju

  Posted 4 months ago

  Hi, Opeyemi Eniola!

  Very good job, you did great!

  If you don't mind, I'll make some comments:

  • you've done the work only for 2 devices - for desktop and mobile. If you don't have intermediate design layouts, it doesn't mean that you as a frontend developer shouldn't make the page work for all resolutions. Your task is to check your layout from the minimum screen resolutions of 320px to 1920px and higher. For example, look at 720px - the page is unreadable. You need to add more @media queries.
  • the orange line in the menu is more for hover, because at the moment of pressing it goes to another page and the line is no longer needed
  • when you go to tasks a little more complex than simple components, you need to pay attention to accessibility. The page is not fully accessible from the keyboard
  • you need to pay more attention to semantics, the page is viewed not only by people, but also by search engines and screen readers. This page should have 3 tags in the body - <header> - the top block, <main> - everything else, <footer> - your signature. The menu needs to be wrapped in <nav>. Images have important content value, they should have an alt with a description, the collection of images at the bottom is a ul list, the basket in the header is a button, the trash can icon in the basket is a button too. Read about semantic tags they need to be used
  • look at how the image jumps when hovering on avatar. To avoid this, use outline or set the block to an initial border with a transparent color

  Otherwise, great, good luck with your development!

  00

  Marked as helpful