Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Responsive e-Commerce product Page using Reactjs

react
HussinSoli•290
@HussinSoli
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Feedback is much appreciated , still learning react had some issues with the context I made the state keeps making infinite loops. I made the slider and the navbar into to components one for mobile and the other for desktop, so is this a good way or there is a a better one?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vee•240
    @JunasVee
    Posted over 3 years ago

    Hi Hussin!

    Your page is responsive and it looks good to me, I can't really mention all of the issues since you said you're still learning reactjs which I think it's common to have difficulties functionalizing particular things. But here are the issues that are such a "big deal" in my personal opinion:

    • The cart, it's one of the main concepts in this challenge. In Ecommerce Product design, having a cart like this makes the customers know what they have been putting on. I saw that you have set the function for it but it doesn't seem working on my device, please let me know if it actually works.

    • Increment and Decrement, I tried to decrease the number when it's 0. it's good that the output doesn't show a negative number, but if you click it 3 times after 0, in order to put it back to 0 it also takes 3 increment clicks, so behind the scene, it is still a negative value without showing it to the output. So instead of creating a string for negative values, when counter <= 0 set its value to 0 too.

    I hope my feedback is helpful.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub