Skip to content
Submitted over 1 year ago

Responsive FAQ Accordion

react, sass/scss
Bogdan Kim•780
@semperprimum
A solution to the FAQ accordion challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I would greatly appreciate any feedback that you may have!

Wanted to build something simple and stumbled upon this challenge :)

Code

Please log in to post a comment

Log in

Community feedback

  • Bruce B•485
    @bbsmoothdev

    Hey, just a few quick issues. You can't have spaces in your id values. So id="Question 1" needs to be id="Question1". Also, I see you are using the aria-controls attribute on each button to associate the button with the paragraph it toggles, which is great, but you forgot an even more important aria attribute, aria-expanded. This attribute goes on the button, not the p element. When the content is not showing then it should be aria-expanded="false". When the content is showing then it should be aria-expanded="true".

    Marked as helpful
  • DEVADE/•80
    @AdeMEDIA

    Nice one mate, Keep it up

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord