Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

responsive faq accordion card

accessibility, bem, cube-css, solid-js, next
Lucas Matheus Martins•180
@lucasmm56
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Incredible challenge! I had great difficulties to finish, maybe it made it difficult to do some things, but, as always, I try to find the most practical way to complete the challenge, feedbacks are welcome!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Finney•3,010
    @Finney06
    Posted over 2 years ago

    Hello there 👋. Good job on completing the challenge !

    Here are some suggestions regarding your code that may be of interest to you.

    HTML 🏷️:

    To clear the Accessibility report:

    The error message "ul and ol must only directly contain li, script, or template elements" typically appears when there is invalid HTML markup in the code. This error indicates that either an <ul> or <ol> element contains an element other than <li>, , or <template> elements as direct children.

    • If you need to include other types of elements within a list, you can nest them within an <li> element.

    • Use a validator tool to check your HTML code for other possible errors.

    Here's an example of valid HTML markup for an ordered list:

    <ol>
      <li>Item 1</li>
      <li>Item 2</li>
      <li>Item 3</li>
    </ol>
    

    And here's an example of valid HTML markup for an unordered list:

    <ul>
      <li>Item 1</li>
      <li>Item 2</li>
      <li>Item 3</li>
    </ul>
    

    By ensuring that your HTML markup follows the specifications, you can avoid errors and ensure that your web page is accessible to all users.

    • The error message "All page content should be contained by landmarks" typically appears when the HTML code does not contain the necessary accessibility landmarks to help users navigate the content of the page. In this case, the <div> element with class "attribution" is not a landmark or a footer element, and therefore it does not provide any navigation aid for users.

    To fix this error, you can do the following:

    • Use HTML5 landmarks: HTML5 introduced several new elements that can be used to define the different sections of a web page, such as <header>, <nav>, <main>, <aside>, and <footer>. By using these elements, you can create a clear hierarchy of content that is easy to navigate for users.

    • Include a footer element: A footer element should be included at the end of the document and contain information about the website or document, such as copyright information or contact details.

    I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

    Marked as helpful
  • Lucas Matheus Martins•180
    @lucasmm56
    Posted over 2 years ago

    Hello, thank you very much for the feedback, I will put it into practice right now!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub