Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 23 days ago

Responsive FAQ Accordion Using Javascript

P
hackz101•90
@hackz101
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm most proud of the fact that I was able to get the javascript out of the way relatively quickly. However, next time I would try to take into consideration how parent/child heights affect layouts.

What challenges did you encounter, and how did you overcome them?

I came across quite a few challenges when going through this challenge, but I will summarize a few:

  • When editing innerHTML, the parent element gets destroyed then recreated. This was causing my event listeners to disappear. I just ended up using insertAdjacentHTML instead.
  • My headings weren't focusable, so I just had to add a positive tabIndex to them.
  • My expand button would only work once. I had to set the variable that evaluates whether the section was expanded or not to within the event listener which was the closure function. This is because only the value was retained and it wouldn't reevaluate.
What specific areas of your project would you like help with?

I noticed that since I have a high resolution screen and I'm working fullscreen, the SVG would just cut off around the 75% mark. I ended up making it tile on the x-axis because I didn't want to stretch the image. Is this way to resolve the issue fine or is there a better way?

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on hackz101's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SASS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.