Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

Responsive FAQ Component using React and CSS Flexbox

accessibility
Shikur•140
@shikurassefa
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

as i said so many times one thing i proud is my front end consistency.

What challenges did you encounter, and how did you overcome them?

to make it look like the design.particularly i cant make the heading of the page to look like the design

What specific areas of your project would you like help with?

i need help on what color should i use for the header,and for each question item

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Gwenaël Magnenat•1,540
    @gmagnenat
    Posted 4 months ago

    Hi, congrats on completing this challenge! It looks great. Below are some improvements that will enhance accessibility, maintainability, and responsiveness.

    Semantic HTML & Accessibility Improvements

    • A <main> landmark is missing. This is crucial for screen readers to identify the primary content of the page.
    • The <section> used is the only block of content, so a <div> would be more appropriate unless a heading (e.g., <h2>) or an aria-label is added.
    • <header> is typically used for content that repeats across multiple pages, like a site-wide navigation or branding. It’s unnecessary here.
    • The icon used is decorative, so its alt attribute should be left empty (alt="") to prevent screen readers from announcing it.
    • The entire FAQ item should be focusable and clickable. Instead of just the icon or text being interactive, the whole FAQ item should function as a <button>. Follow the ARIA accordion pattern and check out this guide on accessible disclosures.

    CSS & Layout Improvements

    • A modern CSS reset is missing. Consider using one like Andy Bell’s reset to ensure consistency across browsers.
    • Avoid using fixed widths in pixels (px) on content. Instead, use max-width in rem for better responsiveness.
    • Follow a mobile-first approach by using min-width in media queries. Additionally, use rem for breakpoints to respect users' font-size settings.

    These improvements will make the solution more robust, accessible, and easier to maintain. Let me know if you have any questions!

    Happy coding! 🚀

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub