Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 8 months ago

Responsive FAQ Page built with JavaScript

accessibility
P
Natalie Smyth•340
@nataliesmyth
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm happy with the amount of time I spent on this project, and that I was able to finish it in a few hours. Originally I made the faq container using position: absolute, and I next time I would keep the container in the flow of the layout and center it so I didn't have to worry about the position of the footer.

What challenges did you encounter, and how did you overcome them?

The biggest struggle I had was getting the plus and minus icons toggle to function correctly, but breaking it down and getting it to work on one and expanding helped me deal with the problem on hand and fix it relatively quickly without getting confused or writing too much code.

What specific areas of your project would you like help with?

Any feedback is welcome! Overall, I'm pretty happy with the result.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Asilcan Toper•2,960
    @KapteynUniverse
    Posted 8 months ago

    Hey Natalie, nice job.

    Looks like you set desktop layout after the 1440px screen size, probably because it says desktop design is 1440px in the style-guide.md but think it would be better to make the desktop layout something around 800-1440 and mobile <800. You can even make something for tablets at the middle.

    Like Claudia said below, on hover effects are missing. You can check pseudo classes for it.

    You can also use details tab for this challenge, with details it is also possible to make it without JS. My solution is a bit old, so i recommend you to check @elisilk solution

    Btw i can't understand, why you set opacity of the icons to .15 in mobile layout?

    Marked as helpful
  • Claudia•730
    @ClaudiaRamirezD
    Posted 8 months ago

    Good job! However, you are missing some details, such as the pointer to show that it is clickable. Additionally, the answers are not accessible with a screen reader

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub