Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive FAQ with Accordeon

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is a temporal solution for the JS of the accordeon

Community feedback

@zineb-Bou

Posted

Hi there, since this is a temporal solution I am dropping some comments that may help you to improve your solution next time.

  1. On mobile screens, the text is overlapping, I think setting an explicit height may cause this kind of problem, so let the container shrink according to the text size.

  2. Anything that is clickable or has a hover effect means it’s an interactive element, the toggle arrow actually it’s a button, so you can wrap the <img> inside a <button aria-label=” toggle arrow”>.

  3. Illustration images are for decoration purposes, there is no information to convey so it's better to hide them from the screen readers using aria-hidden=” true”.

  4. <body> is not taking the total height when scaling down to mobile screens, I would recommend using min-height:100vh instead of heigh:100vh to avoid this problem.

Good luck

Marked as helpful

1

@Alexuva

Posted

Thank you @zineb-Boy for the comments, it really helps a lot! Im not that experienced in responsive and overall accessibility, I got to work harder on that! so I really appreciate your feedback.

0

@shashreesamuel

Posted

Hey good job completing this challenge.

Keep up the good work

Your solution looks great however I think your card is missing a subtle box-shadow

In terms of accessibility issues simply wrap all your content between main tags

I hope this helps

Cheers Happy coding 👍

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord