Responsive Flex card

Community feedback

• 

  P

  Daniel 🛸•44,830

  @danielmrz-dev

  Posted over 1 year ago

  Hello @iOtele!

  Your solution looks great!

  I have a suggestion for improvement:

  • Use <main> to wrap the main content instead of <div>.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  01

  Marked as helpful
• 

  Hassan Moataz•1,860

  @hassanmoaa

  Posted over 1 year ago

  Hello @iOtele!

  Great Job solving the challenge mate congrats 🎉

  Some suggestions for improvements.

  For the font-size it's is better to use rems and ems but px for this project is no big deal.

  font-size: 13px;

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  ➖➖➖➖➖➖➖➖

  Use <main> to wrap the main content instead of <div>. * 📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  ➖➖➖➖➖➖➖

  You can’t put text in plain divs or without an semantic tag:

  Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.

  <h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>

  Other than that you're good, keep up the good work!

  01

  Marked as helpful
• 

  Petrit Nuredini•2,860

  @petritnuredini

  Posted over 1 year ago

  Congratulations on completing your Blog Preview Card project! It's an excellent achievement, and I'm thrilled to see your dedication to developing your front-end skills. Here are a few recommendations for improvements:

  1. Semantic HTML Tags:

     • Consider using more semantic HTML tags to enhance the accessibility and structure of your code. For example, you could use <article> for the main content area and <footer> for the bottom attribution section. This not only makes your HTML more readable but also helps with SEO and accessibility. Learn more about semantic HTML here.

  2. Alternative Text for Images:

     • It's important to provide alternative text for images using the alt attribute. This is crucial for users who rely on screen readers. For instance, <img src="assets\images\image-avatar.webp" alt="Greg Hooper's avatar" /> provides more context. Read about the importance of alt text here.

  3. CSS File Naming:

     • The naming of your CSS file as index.css might be a bit generic. Consider renaming it to something more descriptive, like blog-preview-card.css. This helps in maintaining and understanding the purpose of the stylesheet, especially in larger projects.

  Keep pushing the boundaries and exploring new challenges in web development. Your progress is impressive, and each project takes you one step closer to mastery. Keep up the great work and happy coding! 🌟👨‍💻

  01

  Marked as helpful