Vanza Setia• 27,835
@vanzasetia
Posted
Hi, Abhinav! 👋
Here are a few suggestions for improvements:
- Remove the visually hidden heading: You do not need to add more content to the page. If it needs to be added, a visible heading should be preferred.
- Invalid BEM: If you are following the BEM methodology for your class naming convention,
section__card__contentis BEE (Block Element Element). I recommend creating a new block (card) and then having an element for the new block (card__content).
Great job on fixing the contrast issues! That is a good initiative.
Nice work on the CSS. You are using clamp() for fluid typography and rem unit for font sizes. The grid layout works well too.
I hope this helps. Happy coding! 😄
Marked as helpful
1
Abhinav• 240
@IamAbhiDev
Posted
@vanzasetia Thanks a lot for your feedback! I'll make sure to apply this as soon as possible and improve my code. Thank you for your time! 😃
0
Vanza Setia• 27,835
@vanzasetia
Posted
@IamAbhiDev You are welcome! 👍
0
