Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive four card feature section using CSS Grid and Media Queries

Manuel 50

@ManuelCh02

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Do you think is best practice to create new files (Breakpoints) instead media queries? Is it a good semantic? I'd really like your feedbacks 😉😉

Community feedback

Ken 935

@kenreibman

Posted

For small projects like this I believe media queries are fine.

You are also missing an h1 in your entire project. All HTML projects should start with an h1. In my project, I set the h1 to "Powered by Technology", h2 was "Reliable, efficient delivery" but that was my vision.

You should never use heading tags depending on their style, size, and font weight. Always focus on having that correct heading hierarchy. You can set style and all that in CSS later.

Whenever you use a section tag, you should always have heading elements as child elements or it isn't semantically correct. In your case, <section class="cards-section"> lacks heading tags. Instead of using article elements, I would just turn them into divs.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord