Faris P• 2,810
@FarisPalayi
Posted
Hey @erelita, good job on this one 👌. The site is responding well to different screen sizes.
A few suggestions from me are:
- The
alttag for the icons should be empty, since it doesn't provide any context or extra information; so that assistive technologies can ignore the image. - I think you've used the BEM methodology correctly. One thing I noticed is that,
card-container__border border--oneclasses should becard-container__border card-container__border--onetake a look here. But, BEM is flexible, so you can use it any way that works for you. So, it's not a hard rule.(also if it is meant to be reusable throughout the site, then it's not a problem) Here's a BEM cheat sheet website that can be used for reference. There are a bunch of good articles' link as well. - Apart from these two minor things, everything looks excellent.
That's all from me. Have fun coding ✨
Marked as helpful
2
Erel Ropeta• 385
@erelropeta
Posted
@FarisPalayi Thank you so much! I'll make the alt tag empty on this one and apply to my other challenges :)
And I really appreciate the cheat sheet website for BEM <3
1
Faris P• 2,810
@FarisPalayi
Posted
@erelita No problem, glad I could help :)
0
