responsive four card section using, sass-grid

Community feedback

• 

  Miguel Silva•490

  @migsilva89

  Posted over 3 years ago

  Amazing work, congrats.

  I would add max-width from 1600px, cause if you go bigger the side cards are getting separated from the middle ones.

  For the rest looks perfect, well done!

  Regards, Miguel Silva

  12

  Marked as helpful
• 

  Jordane Gengo•590

  @jgengo-alt

  Posted over 3 years ago

  Hello there 👋

  First of all, good job 🚀💣

  📋 To position your images to the card, the simplest way to me would have been to actually add a position: relative to your container-cards__card div, and then add a position: absolute; bottom; 2em; right: 2em to your img. In a nutshell, by doing that you are positioning your card with absolute value inside the relative space of your card.

  📋 Everything looks extremely huge from my screen, as another peer mentioned a max-width would have been a good addition. 🔥

  📋 Another point you could have re-use your grid with the mobile view, just by changing the grid-template-columns: 1fr .

  📋 Also, with your grid I see you using some margin I would suggest using the gap or grid-gap :)

  Once again! Good job 💪

  Keep going 🌱

  01

  Marked as helpful