Looking to hire developers?
Submitted
@tassieoshiro
I had a little difficulty moving the icon to the right of the card, still getting used to how to space the elements. Any criticism feedback is appreciated.
@migsilva89
Posted
Amazing work, congrats.
I would add max-width from 1600px, cause if you go bigger the side cards are getting separated from the middle ones.
For the rest looks perfect, well done!
Regards, Miguel Silva
Marked as helpful
@tassieoshiro
Posted
@migsilva89 yea! I didn't check the bigger screens, thanks, brother..
@migsilva89
Posted
You are welcome :) @tassieoshiro
Keep going!
@jgengo-alt
Posted
Hello there š
First of all, good job šš£
š
To position your images to the card, the simplest way to me would have been to actually add a position: relative to your container-cards__card div, and then add a position: absolute; bottom; 2em; right: 2em to your img.
In a nutshell, by doing that you are positioning your card with absolute value inside the relative space of your card.
š Everything looks extremely huge from my screen, as another peer mentioned a max-width would have been a good addition. š„
š
Another point you could have re-use your grid with the mobile view, just by changing the grid-template-columns: 1fr .
š
Also, with your grid I see you using some margin I would suggest using the gap or grid-gap :)
Once again! Good job šŖ
Keep going š±
Marked as helpful
@tassieoshiro
Posted
@jgengo-alt thanks brother! that was really helpful.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
