Skip to content
Submitted over 4 years ago

Responsive, GRID, SASS

Samyr Oliveira Ribeiro•215
@SamyrOR
A solution to the Four card feature section challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hello everybody, i expect you have a nice day.

Here go another challenge, all feedback well be welcome.

Code

Please log in to post a comment

Log in

Community feedback

  • Szymon Rojek•4,540
    @SzymonRojek

    Hi Samyr,

    View code button is not referencing to the GitHub files (maybe there is a general problem with it today). There is another way to arrange the blocks differently - column on mobiles, then two rows with two boxes (for tablets) and final design version on desktop, what do you think about it? Also, try to fix the HTML issues report above.

    Greetings :D

  • Basile Raiwet•175
    @BasileRaiwet

    Hi Samyr !

    Great work ! I just see some points you can improve :

    • About semantics : avoid to use many h1 on the same page. h1 and h2 are here for the title and subtitle of the section. So It's better if you use h3 (or other, depend of the situtation) for the boxes titles
    • about the container width : design is based on a 1110px grid and I think it's better to limit the width of the container to this size because if your solution stretch to 80% of the viewport with (like it is actually), the result could be really different on larger screens. (As an example, look how this page container is defined. It's, I think, the most common way to define container width)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord