Responsive Homepage built by HTML/SCSS/JS/jQuery

Community feedback

• 

  tediko•6,700

  @tediko

  Posted about 4 years ago

  Hello, MetisT! 👋

  Great job on this challenge! I have a few suggestions to improve your solution:

  • I am not a big fan of these box-shadows. This is my feeling but i think in this specific project simpler is better.
  • You can easily rework your slider to be infinite. I mean, it won't stop after your reach last slide, but it will back to beginning of your slides. Try this code:

  $('.arrow-left').click(()=>{
      if(i>0){
          i--
          imageSlide(i)
          checkSlideState(i)
      } else if (i <= 0) {
          i = 2;
          imageSlide(i);
          checkSlideState(i);
      }
  })
  

  $('.arrow-right').click(()=>{
      if(i<2){
          i++
          imageSlide(i)
          checkSlideState(i)
      } else if (i <= 2) {
          console.log('hello');
          i = 0;
          imageSlide(i)
          checkSlideState(i)
      }
  })
  

  • Your padding on .upper-section .right is too big on mobile version, instead of 80px try for example with 20px so your content isn't missplaced.
  • The same problem occurs with .lower-section .middle-text. You can remove margin: 40px; from this element on mobile resolution.

  Good luck with that, have fun coding! 💪

  10
• 

  MetisT•275

  @greatmetis

  Posted about 4 years ago

  Thanks @tediko for your time!!

  • I totally agree with you about the box-shadows. That is a try although it's unsuccessful experience, I learnt the lesson from this. I thought it could make the buttons more attractive, while apparently I even doubt my own decision. 😅

  • Thanks for pointing out the problem for the layout in mobile screen. I didn't see the misplace of those sections. It's big shame for me while I have edit them, and thank you😀

  • In terms of infinite slides, I have thought about it. While the reason why I added the indicator for the slide is to let users know the slide has been the end. However, I do understand loop the slide could be more user friendly. So, I decided to stick with you suggestion!

  To sum, I have learnt lots from this challenge, particularly the aspects of user-friendly and designer's eyes.

  Again, I really appreciate your time on my challenge!!

  00