Responsive HTML-CSS-JS - Advice generator app

Community feedback

• 

  Ahmed Bayoumi•6,700

  @Bayoumi-dev

  Posted almost 3 years ago

  Hey Hugo, It looks good!... Here are some suggestions:

  • Use <button class="dice-div"> instead of <div class="dice-div">... Buttons are used for actions.

  <button class="dice-div">
        <img class="dice" src="/images/icon-dice.svg" alt="Advice Generator">
  </button>
  

  • Use the quotation element instead of the heading element to add more semantics to your project... ---> <q>: The Inline Quotation element

  • Use REM for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?

  Hope this help!... Keep coding👍

  11