Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Insure landing page using HTML SCSS and js (Desktop first)

Talhaβ€’ 120

@TalhaAmjad0034

Desktop design screenshot for the Insure landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


It is my first upload in Frontend Mentor, I've learned a lot from this project,

I have a question how can i all lazy opening of nav menu in mobile version, i struggled a lot but in vain.

Thanks for having a look and giving me any feedback/criticism so I can improve :)

Community feedback

Talhaβ€’ 120

@TalhaAmjad0034

Posted

Thank you soo much for your feedback, I will not repeat these mistakes from now on. ✨

0
Dineshβ€’ 1,115

@Dinesh1042

Posted

Hello, Talha!πŸ‘‹ Fantastic work on your first challenge, Here are my few suggestions

  • When you are trying to apply transition property for display:none to display:flex, transition properties do not work. The reason is display:none property used to remove element from the dom. display:flex property is used to make flexible box layout it cannot be partly displayed. That is why the transition property does not work. You can use keyframe animation @keyframes navAnimation{0%{display:none; opacity:0; } 1%{display:flex; opacity:0;}100% {opacity:1; }}
  • another way is using transform property set transform:translateY(-100%) property in mainMenu this moves mainMenu out of the screen. When the nav is in the active stage change the transform property to transform:translateY(0).
  • Consider using the h1 element as a top-level heading only the reason for that is h1 elements are treated as top-level headings for many screen readers.
  • Your .links should be accessible for screen readers use <a href=""></a> tag for all your social link and Add some aria-label for your .links. This attribute is used to define a string that labels the current element. In your case these anchors have icons inside so screen readers users won't know what it is.

Wish you Happy Coding!πŸ’ͺ

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord