responsive interactive rating component with flex and js

Please log in to post a comment
Log in with GitHubCommunity feedback
- Account deleted
Hi
Congratulations on completing the challenge. I will go over some of the issues I see.
You also should stop using <div> so much and use more semantic HTML. HTML landmarks are important for adding structure to your page and landmarks such as <header>, <main>, <nav> and <footer> aid navigation in assistive technologies such as screen readers and for keyboard accessibility. You should wrap your markup in <main> , if you decide to keep the attribution in future wrap it in a <footer> element. Semantic HTML is important, here are some links if you want to read more on semantic html and accessibility.
Page must have a level one heading <h1> and the can be multiple <h1>'s on a page. You should wrap "How did we do " and "Thank you" in a <h1> each.
There is no need for <br>. In HTML <br> is a self closing tag so a closing slash is not necessary, it is only needed in XHTML. The rating <div> is a block element so there is no need for a line break. To create distance between rating and <button> use margin.
I would suggest you read the mdn(mozilla developer network) form guides as this challenge would be better completed using a form with radio or check buttons and client side validation. if you do not know about it, it is a great free resource.
I hope this is of help to you
Happy coding.
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord