Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

Responsive Intro Component with Signup Form using Flexbox

Aviral Sharma•220
@aviralsharma07
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Shahin Aliyarli•700
    @sliyarli
    Posted almost 2 years ago

    Sure, here are some suggestions to help improve the code provided:

    1. HTML Structure and Semantics:

      • Make sure to close all HTML tags properly. For example, some of your input tags are missing the closing angle bracket.
      • Consider using semantic HTML tags like <header>, <nav>, <section>, <article>, and <footer> for better document structure and accessibility.
    2. CSS Styling:

      • Use CSS variables for colors, fonts, and other repeated values to make it easier to update the styling throughout your application.
      • Organize your CSS styles into meaningful classes and IDs to improve readability and maintainability.
      • Consider using a CSS preprocessor like Sass or Less to simplify your stylesheets and make them more modular.
    3. Responsive Design:

      • Ensure your webpage is responsive by using media queries. Test it on various screen sizes and devices to ensure it looks good and functions correctly.
    4. JavaScript:

      • Separate your JavaScript code into functions for better code organization and readability.
      • Consider using event delegation to handle form validation more efficiently.
      • For email validation, you can use the HTML5 type="email" attribute on the email input field to ensure a valid email format.
    5. Error Handling:

      • Improve the error handling mechanism. Right now, it displays errors below each input field. You could consider using a single error message area that dynamically updates with relevant error messages.
    6. Comments and Documentation:

      • Add comments to your code to explain its functionality, especially in JavaScript. It will make it easier for you or others to understand the code in the future.
    7. Form Validation:

      • Currently, you are checking for errors when the user clicks the "Claim your free trial" button. Consider adding real-time validation as the user types to provide immediate feedback.
    8. Accessibility:

      • Ensure your website is accessible to users with disabilities. Use appropriate ARIA attributes and labels for form elements.
    9. Testing:

      • Thoroughly test your form on different browsers and devices to ensure cross-browser compatibility.
    10. Performance:

      • Optimize your images and assets for faster loading times.
      • Consider using a Content Delivery Network (CDN) for common libraries like Google Fonts to improve page load speed.
    11. Version Control:

      • Consider using version control systems like Git to track changes in your codebase and collaborate more effectively.
    12. Security:

      • Implement server-side validation and security measures to protect against malicious input.
    13. User Experience (UX):

      • Enhance the user experience by providing clear feedback when the form is submitted successfully.

    Remember that coding is an ongoing learning process, and there's always room for improvement. These suggestions should help you enhance your code and skills.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub