Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 2 months ago

Responsive landing page

Dule•90
@Harty1989
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of my start on projects.

What challenges did you encounter, and how did you overcome them?

I hope this will work

What specific areas of your project would you like help with?

My biggest problem was send all on this page

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Curtley•120
    @curtleyAk
    Posted 2 months ago

    Well Done! You did well. You need to remember the parent-child relationship. Example: in your 'body' you 'display: flex;' which is great, but this also means the children contained within the 'body' will also adopt the new positioning type, so it's unnecessary to place it again in the '.container' div.

    Also, if you apply the font family to the 'body' element, you won't need to repeat it in the H1 and p elements.

    Marked as helpful
  • P
    Michael•180
    @Networksentinel
    Posted 2 months ago

    Hi, if you would like to write more simple CSS code (and less lines) you could use very common shorthands.

    This is your code from style.css:

    p {
      font-size: 15px;
      font-family: "Outfit", sans-serif;
      font-optical-sizing: auto;
      font-style: normal;
      text-align: center;
      margin-left: 30px;
      margin-right: 30px;
      margin-top: 10px;
    }
    

    You can achieve the same result with this code:

    p {
      font: normal 15px "Outfit", sans-serif;
      font-optical-sizing: auto;
      text-align: center;
      margin: 10px 30px 0;
    }
    

    The font shorthand packs multiple font-related properties into one line:

    font: [style] [weight] [size]/[line-height] [family];
    

    Similar for the margin shorthand:

    margin: top right bottom left;
    

    BONUS TIP

    Margin shorthand rules - depending on how may values you define:

    • 1 value: applies to all sides → margin: 10px; → top, right, bottom, left = 10px

    • 2 values: → margin: 10px 20px; → top/bottom = 10px, left/right = 20px

    • 3 values: → margin: 10px 20px 30px; → top = 10px, left/right = 20px, bottom = 30px

    • 4 values: → margin: 10px 20px 30px 40px; → top = 10px, right = 20px, bottom = 30px, left = 40px

    NOTE: the exact same logic as for the margin shorthand applies for padding, border-width, border-style, border-color, inset, border-radius

    I hope this helps! Keep up the good work :-)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub