Responsive landing page HTML, CSS

Solution retrospective
comments and suggestions welcome
Please log in to post a comment
Log in with GitHubCommunity feedback
- @norman02
Thanks! I am pretty new to this. I will definitely use these suggestions
- @shashilo
Hey John. You did a great job using all the assets. It looks great, but it is missing some details. Here are the areas of improvement that I noticed:
- You should create a
.container
withmax-width: 1110px
and used it within your sections. - Overall, paying attention to the detail of the design. For example, the hero section's title font size, call to action button's font size and alignment, etc. If you look at the design or overlay it onto your project, you'll see that you're close, but not pixel perfect to the design.
- Instead of setting
display: flex;
to every main section, I'd usedisplay: flex;
on the parent and setflex-basis: %
to create a width. You can also addalign-items: center
on the parent instead of each child element. - The
box-shadow
of thesection
's are too heavy. - Footer is missing the huddle image. Also, the content should start below the logo. Missing the social media icons as well. I know there isn't active states, but you should practice making all links real links.
- You should create a
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord