Hello, Rahul kumar Gautam! 👋
Good job on this challenge! Your solution responds well and looks nice. Some tips from me:
- Since your
.intro
image is decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers. - Add
:focus
pseudo class to interactive elements like anchors, buttons etc. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles. - Your image with hamburger icon should be a
<button>
element since it trigger some action. footer_icons
should be wrapped with<a>
tags since it will redirect to other page.
Good luck with that, have fun coding! 💪
@RahulKumarGautam1636
Posted
@tediko yes sir, of course i will explore the points you just told me about to improve my work. Thank you for these suggestions, i really appreciate it.