Skip to content
Submitted over 3 years ago

Responsive landing page

Mateus Abdallah•20
@mateusAbdallah
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I had some difficults about the css responsive. Feedback welcome!

Code

Please log in to post a comment

Log in

Community feedback

  • P
    MELT•170
    @MeltedGreenVelvet

    Good job on completing your first challenge! You should be proud of yourself.

    My suggestions:

    • I'd recommend looking into flexbox! It'll help out with general alignment issues, including responsivity. It makes building a layout so much easier.
    • I feel that your QR image should be set at a higher percentage, possibly at a 100% with some padding/margin usage. Setting the QR image smaller than it needs to be will affect UX (user experience).
    • I know readmes can be a pain to write, but I always recommend writing them for completed repos, even partially if you don't have everything you need for a fully fleshed out README.md. Documentation is very important in the development world! Not saying hiring managers or recruiters will examine every inch of your github, but not having a README.md is a red flag to them. Plus, it's good practice for both yourself and for teammates. Your future self will thank you!
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord