Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page use only html and css without flex and grid

#accessibility#cube-css

@GhulamMohyuldin

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


There is nothing difficult . I tried my best ,did not loose hope and got result.

Community feedback

Elaine 11,420

@elaineleung

Posted

Hi Ghulam, welcome to Frontend Mentor, and congratulations on completing your first project! Happy to hear you managed to finish it and didn't give up, which isn't always so easy, and I think we all have been there too.

Anyway, I don't have any feedback to give since @AntoineC-dev gave you some excellent tips already, so my only suggestion is just to follow his advice, and hopefully you can learn a few things there that can make it a bit easier when working on future projects. Keep going, you're doing great! 😊

Marked as helpful

1
AntoineC 1,180

@AntoineC-dev

Posted

Hello Ghulam Mohyuldin. Congratulations on finishing your first project on the site. It is a good work!

I have some small suggestions for you to make it a bit closer to the original design:

  • I see that you user some rather large margins on your main component. I guess you did it to center it on your screen. But there are more consistent solution for this using either flexbox or grid. In fact on my screen it is not centered with your current solution. Here is a little snippet of code that would fix this issue:
body{
    background-color: rgb(204, 242, 248);
    font-family: 'Poppins', sans-serif;

    min-height: 100vh;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
}
  • Also instead of using % to size your card i would give it a max-width like so:
.imgandcont{
    width: 16%; -- Remove this
    margin: 100px auto 100px auto; -- Remove this

    max-width: 18rem; -- Add this
    margin-bottom: 2rem; -- Add this
    
    border-radius: 12px;
    text-align: center;
    background-color: aliceblue;
}
  • Lastly instead of giving a property width: 89% on your img to prevent it from overflowing its container; i would add a rule in the top of my css file like so :
img {
    display: block; 
    max-width: 100%;
}

This last rule would be part of the CSS Reset/Normalize which you should add to all your projects. Here is an example that you could adapt to your projects.

Again good job with your solution and happy coding 😀

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord