Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

Responsive landing page using CSS flex

Lelovics László•80
@Laloka2000
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Alaa Mekibes•2,040
    @alaa-mekibes
    Posted 5 months ago

    Hi @Laloka2000 i see you have some issues with your code.

    • Use picture tag to add an image for desktop and how to change it for mobile like this :
    <picture>
    <!-- Here Add all the images with small screen -->
             <source
                        media="(max-width: 375px)"
                        srcset="images/image-product-mobile.jpg"
                        >
    <!-- Here Add the default image -->
             <img src="images/image-product-desktop.jpg" alt="Product image">
    </picture>
    
    • Use css variables to improved maintainability, flexibility, and reduced redundancy within CSS code like this :
    :root {
        --bg-color: hsl(210, 46%, 95%);
        /* Add your other colors here */
    }
    
    body {
        background-color: var(--bg-color);
        /* Other properties */
    }
    
    • Add some letter-spacing to the "PERFUME". And change the font-family

    • Improve the title size. And change the font-family also.

    • Change the font-family of the paragraph.

    • Change the font-family of "$149.99" and make it bold.

    h1, .price {
        font-family: "Fraunces", serif;
        font-weight: 700;
    }
    p, span , a {
        font-family: "Montserrat", serif;
    }
    
    • idk why you use another svg icon on the button, you have icon on images folder you should use it.

    • This is my solution: Product preview card component

    You're on the right track, @Laloka2000, keep up the awesome effort!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SASS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub