Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Responsive landing page using CSS flexbox

itcss
Gamajunior•30
@Gamajunior6
A solution to the Order summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Your responses are much appreciated.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Tjaša Žilavec•590
    @TjasaZil
    Posted almost 3 years ago

    Hi Gamajunior!

    Good job on your design! I have a few suggestions for you to consider, that will make your solution closer to the design.

    Here are some of the CSS changes that you can implement:

    • You can change height: 400px; in the body tag to height: 100%. After that, you can add:
    position: absolute;
    top: 50%;
    transform: translate(0, -50%);
    

    this will center your card on all devices.

    • You can style your button with border: none; to get rid of the border around it and make it look closer to the solution.

    Some HTML changes:

    • The <div class="Card" > around your image is not necessary for this project, so you can delete it.
    • Instead of using <br> in your <p> tag it is better practice to style the text with CSS. Try adding width:270px; to .Content and deleting <br> from HTML. It will give you the same result.
    • Look into semantic HTML. Using tags like <main>, <header>, <footer>... makes the site more accessible and most of the time also easier to style. Try to use <div> only when necessary.

    Hope it makes sense, you can have a look at my solution for this challenge to have an idea.

    Marked as helpful
  • Account deletedPosted almost 3 years ago

    Hey Gamajunior, congratulations on completing the challenge! You did a great job 😉

    Let me give you some little tips for optimizing your code:

    • remove width: 100%; height: 400px; properties from body because not necessary
    • add main tag and wrap the card for improve the Accessibility
    • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
    • remove margin from Wrapper class because with flex they are superfluous
    • after, add min-height: 100vh and margin: 0 to body because Flexbox aligns child items to the size of the parent container
    • instead of using px use relative units of measurement like rem -> read here

    Hope this help! Happy coding 😁 by Travolgi

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SASS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub