Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 10 months ago

Responsive landing page using css Grid

accessibility, pure-css
Emmanuel Boluwatife Janet•40
@Tifem
A solution to the Recipe page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Being able to achieve the challenge

What challenges did you encounter, and how did you overcome them?

how to center my div using grid properties, i was able to overcome it by making research online

What specific areas of your project would you like help with?

working more on the mobile responsiveness

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted 10 months ago

    This all looks very very small! And doesn't have the right fonts. I think you need to try and refactor it to look much closer to the original design if you can.

    Here is some feedback

    • Make sure you understand the difference between padding and margin
    • Look up how to write good alt text on images.
    • Set the body font size to be the same as what is defined in the style-guide, except converted to rem before using it in code. This tells you what size the default text should be, like the paragraphs throughout this. You won't need to set a font size on the paragraphs I think.
    • Link fonts from Google in the HTML head. They will provide the code you need once you've chosen the specific families and weights you want.
    • Headings should ideally go in hierarchical order an not skip heading levels. That means "preparation" should be a h2.
    • I recommend you give the th elements scope="row" so it is programmatically clear that they are headers for the rows and not columns.
    • This component must not have a width. All it needs is a max-width in rem. Because you've given it an explicit pixel width in the media query it is overflowing my screen.
    • The only thing that really needs to change in the media query is the component should be flush with the screen edges on mobile and not in larger screens. Maybe border radius too, and a top/bottom margin on larger screens.
    • Ideally, the mobile style should be the default and the desktop change (the extra space around the component) should be added in a min-width media query, where that media query itself is defined in em or rem.
  • P
    Steven Stroud•11,890
    @Stroudy
    Posted 10 months ago

    Hey, Great job with this solution you should be proud, A few things I noticed,

    • Missing a <meta> description tag for SEO purposes,
    • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
    • Your heading elements are not in a sequentially-descending order, <h1>``<h3>``<h2>, Should be <h1>``<h2>``<h3>``<h4>, You can have multiple <h2> but they have to be in order, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies.
    • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
    • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
    • Another great resource for px to rem converter.
    • Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,
    • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
    • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.

    I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub