Prince Roy• 1,210
@iprinceroyy
Posted
Hey @hanzlasaadi, Great work. You need to focus on some points here:
- Don't use h1 multiple times, there can be only one h1 through the web page.
- Those avatar images with title, you can use figure & figcaption tag for that figcaption.
- Use the blockquote tag for quotes text.
- span is an inline tag, it can't be used as a block tag. Use div for the block.
- Increase the padding of the container to match with provided design.
.container{padding: 5rem; } - Use relative unit instead of px unit. 1rem = 16px.
Hope it adds to your learning. Happy coding :)
Marked as helpful
1
Hanzla• 30
@hanzlasaadi
Posted
@iprinceroyy Thanks for the tips. I updated my repo with your suggestions☺. I was having problems with naming headers containing the figure and the names, so I tried to use the span for its inline property but didn't work so I kinda left it there because it was working😁. Thanks BTW
0
