Skip to content
Submitted over 2 years ago

Responsive landing page using CSS Grid & Flexbox..

Ahmad•70
@folaa01
A solution to the Blogr landing page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

My first website with much contents and responsiveness... Really glad I was able to get the javascrip aspect...

Code

Please log in to post a comment

Log in

Community feedback

  • Adriano•42,870
    @AdrianoEscarabote

    Hi Ahmad, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every pages needs a <h1> to show which is the most important heading. So replace the <h2> with <h1> and follow the sequence h1-h5

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

  • Account deleted

    Hey @folaa01, great job on this project!

    Some suggestions to improve you code:

    • Your logo needs a descriptive Alt Tag. The logo is arguably the most important part of you page. If a screenreader was to read the Logo it wouldn't say anything.

    • When the user clicks on any of you "buttons" your expecting them to direct to a different page in your site. Currently, you buttons won't to that. You want to use an Anchor Tag <a> for this to happen.

    • Your headings are not being used properly. For "Introducing an extensible editor", "Robust content management", "Free, open, simple" and "Powerful tooling" you are using an <h4> heading. This need to be <h3> headings. When using headings you can't skip between them

    • To make CSS Variables (:root) easier to deal with, you can give them custom names, like "--background-color", "button-color", etc...

    • For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

    More Info:

    https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

    https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

    Happy Coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord