Skip to content
Submitted over 3 years ago

Responsive Landing Page using html/css/javascript

Abdullah Nassif•405
@AbNassif
A solution to the Base Apparel coming soon page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Struggled a bit with a problem caused by the content overflowing the body element. Realized that since I assigned a height of 100% for both the HTML and BODY, it was wrong to give the MAIN element a height of 100% as well, as you want it to pay attention to the height of the content inside of it not what is available by its parents.

Let me know if you have a better approach, and thank you for your time!

Code
Loading...

Please log in to post a comment

Log in

Community feedback

  • Aakash Verma•9,500
    @skyv26

    Hi! Abdullah, Really nice work, even it is responsive too. But still there are some issues in your work and it takes only 20 min max to fix all issues that I am going to tell you via this feedback

    1. The main part of this challenge is email validation and I would say you made it nice, I mean the custom message and icon you placed perfectly. But your email validation logic is not 100% correct. As I tried abc@gef and hit button then it successfully submit without any issue. So I think it should need to fix.

    2. In your mobile view your text content and email submit button is not aligned properly. I mean in mobile view your button is touching the right edge of mobile screen and your main text need some margin at both side (left and right) in order to make it little bit good to eye.

    Overall Nice work. I hope you understand above minor issues.

    Best of luck

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord