Responsive Landing Page using media queries

Community feedback

• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225

  Posted over 1 year ago

  Hello there 👋 @Chiblessed.

  Good job on completing the challenge !

  Your project looks really good!

  I have suggestions about your code that might interest you.

  Consider changing the background-color of the body element to hsl(212, 45%, 89%).

  body {
    background-color: hsl(212, 45%, 89%);
  }
  

  I hope it helps!

  Other than that, great job!

  Happy coding.

  20
• 

  Dêvid Teófilo•240

  @devid8642

  Posted over 1 year ago

  Firstly, congratulations on the solution.

  I have some suggestions for your project:

  Consider structuring all the content on your HTML page using semantic tags, in this case <main> and <article> for the card. See more about semantic tags here.

  It's not interesting to use tags like <br> to position like you did, consider doing this in CSS because it breaks your layout. As you centered the card using position, depending on the display, the texts may end up leaving the card.

  I recommend that you remove the <br> and to center the card use the following, considering the card inside <main>:

  main { /* or .container */
     display: flex;
     align-items: center;
     justify-content: center;
     min-height: 100vh;
  }
  

  Centering the card without using position and removing <br> will certainly ensure that the layout is more uniform across existing display varieties and facilitate responsive design.

  Even though you applied the sources to the project, you did not upload the assets directory to GitHub and therefore they do not load on the page.

  As this is a simple project, the responsive design probably became a problem due to the layout techniques you chose to use, I recommend using flexbox to center the card and without using <br> to position the texts (research the property text-wrap) you probably won't even need to apply any additional CSS rules in the mobile media query, just change the width of the card.

  I hope you found my comment useful, again congratulations on the solution.

  12