Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page using media querry

Tochukwuβ€’ 90

@kelvtmoney

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


just completed my responsive landing page, reviews are highly appreciated

Community feedback

Leonardβ€’ 1,025

@leoikeh99

Posted

Good solution, i have a couple of feedbacks:

  • For the button it better to set only the padding for the top and bottom and then set a width of 100%, i.e.: padding:1rem 0;, this will help with overall responsiveness
  • For the right side where you have the h3 there are couple of ways to make sure the img and the plain text are properly vertically aligned, you could set the h3 to display: flex and align-items: center, this will help with the alignment

Marked as helpful

0

Tochukwuβ€’ 90

@kelvtmoney

Posted

@leoikeh99 thanks a lot for the feedback, was really helpful

1
Abdul Khalid πŸš€β€’ 72,160

@0xabdulkhalid

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
  • So fix it by wrapping the <div class="content"> element inside the semantic element <main> element in your index.html file to improve accessibility and organization of your page.
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

CSS 🎨:

  • Use min-height: 100vh instead of min-height: 700px;, to properly center the component both horizontally and vertically
  • Setting the height to 700px may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation
  • min-height says that the minimum height is some value but that the element can continue to grow past that defined height if needed (like the content inside makes it taller or whatever).

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

1

Tochukwuβ€’ 90

@kelvtmoney

Posted

@0xAbdulKhalid thanks a lot for the feedback, it was really helpful and encouraging. I will improve on the code

0
Abdul Khalid πŸš€β€’ 72,160

@0xabdulkhalid

Posted

@kelvtmoney Glad you found it helpful ! 🀠

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord