Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Responsive Landing Page, Using React & Bootstrap

bootstrap, react, jss
C.J. Cline•250
@SiegeTank-90
A solution to the Space tourism multi-page website challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Thanks to F.E.M. for putting up the site and setting up these free challenges. Feed back is welcome on any parts, but in particular I'm looking for anything, that would be more likely done in a working environment, if this had been done to work with a team of developers what kind of change would have been made?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Zineb Boutaa•750
    @zineb-Bou
    Posted over 3 years ago

    Hi there, congratulation on completing this challenge, taking a quick look at your solution I think there are a couple of things that need some improvement

    1. On some pages, there is a horizontal scroll bar, setting an explicit width to any container or element may cause this problem. try to fix that.
    2. The background images are a bit more zoomed out.
    3. On the Destination page (desktop version), on the planets navigator, options are overlayed on top of each other.
    4. Try to use the right Html semantic elements, for instance in navigators, instead of using <h5> inside a <div>, <ul> is more adequate for that.
    5. Headings in HTML [<h1> ..... <h6>] are used to construct a table of contents for a document, so avoid using heading elements to resize text. Instead, use the CSS font-size property.

    Happy coding

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub