@vanzasetia
Posted
Hello, Felix! 👋
Congratulations on finishing this challenge! 👏 Nice work on this challenge! 🙌
I have some feedback on this solution:
- Accessibility
- There's no
header
landmark in this challenge. The first section should be asection
element that lives inside amain
element. It's commonly known as hero section. - The logo images are important content of the website. They allow users to know on which website they are currently at, especially the users of assistive technology. Use the company name as the alternative text of the logo.
- For the Download buttons, they should be link elements with the
download
attribute instead. - For any decorative images, each
img
tag should have emptyalt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only, except the logo and social media icons. - Change all the
h3
top
. The content below each heading is too small. <a href="#" class="footer_social-link" title="facebook">
I would recommend usingaria-label
instead oftitle
attribute. I don't think thattitle
attribute would be pronounced by screen reader.
- There's no
- Styling
- I notice that you are still using
px
unit. I would recommend converting all thepx
torem
units. That way, everything will scale properly when the user changes the font size setting.
- I notice that you are still using
I hope this information is useful! Keep up the excellent work! 👍
Marked as helpful
@FelixCriollo
Posted
@vanzasetia Many thanks for the advices, I just implemented most 💪💪💪
@vanzasetia
Posted
@FelixCriollo You did a fantastic job with the updates! 👏
I notice that there's a companies section
, all the companies' logos are important images. In real website, this section is going to tell that these are the companies that have used the product.