Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Responsive landing page using scss

sass/scss
Lasha•20
@lashagelashvili
A solution to the Clipboard landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback is appreciated, especially about html structure, responsive and scss.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Anna Leigh•5,135
    @brasspetals
    Posted over 3 years ago

    Hi, Lasha! Congrats on submitting your first solution! 🎉

    When it comes to your HTML, you did a very good job overall. Just a few suggestions:

    • Adding a visually hidden heading to your .section-img to describe to screen readers what that section is - something like “Used by the the following companies”. Here’s an article that describes different methods to add text just for screen readers. Adding alt text descriptions of each logo would be a good idea in this section too, so that screen readers will know what companies are using the product.
    • The .footer-nav can be a nav element instead of a div to give it more semantic meaning.

    For responsiveness, your paragraphs get quite stretched out before switching to the desktop layout. You may want to consider adding max-widths to them. Using ch units for this might be handy.

    Marked as helpful
  • Shashree Samuel•8,860
    @shashreesamuel
    Posted over 3 years ago

    Hey good job completing this challenge

    Keep up the good work

    Your solution looks great however I think that the following should be considered

    • The title of the website should be a bit bigger

    • The header should have a background image as seen in the design

    • The titles for each section should be a bit bigger

    I hope this helps

    In terms of your accessibility issues simply wrap all your content between main tags

    Cheers Happy coding

    Marked as helpful
  • Rohit Kumar•560
    @rohitKumar38344
    Posted over 3 years ago

    Everything looks good. You just forget to add background image on header section

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub