@carlwicker
Posted
Hey ya Dusan, all looking good however I've noticed a few small issues.
- When resizing the page width, section text content has no padding.
- When hitting the media query breakpoint the mobile navigation briefly appears (something to do with your transition animations I would imagine).
- Finally, fix those accessibility errors in your solutions report.
Keep up the great work.
Marked as helpful
@dusanlukic404
Posted
@carlwicker thanks
@dusanlukic404
Posted
@carlwicker I don't know why I have accessibility issues. This hasn't happened to me before, but I did not write this HTML code, the classes are completely different and also the semantic elements are omitted when I see the project via inspect element. Do you maybe know what's going on here? 😕
@carlwicker
Posted
@dusanlukic404 containing the page content in <main> tags should fix most the problems I believe.
@carlwicker
Posted
@dusanlukic404 there should only be one set of nav tags.
@carlwicker
Posted
@dusanlukic404 the final fix is having one set of h1 tags on the page, so just make the first section heading a h1 tag.
@carlwicker
Posted
@dusanlukic404 I’ll check to see if mine are omitted, I have a feeling they are omitted in the browser but need to check
@carlwicker
Posted
@dusanlukic404 just checked my latest project and they are not omitted in the browser... https://react-job-listing-with-filter.herokuapp.com
...but that maybe because I assigned a class to them.
So... in your case, try...
- wrap the sections in <main> tag.
- replace the nav tag in the footer with div
- 1x h1 element on the page
I think that should fix it.
Marked as helpful
@dusanlukic404
Posted
@carlwicker i will try that, thank you for your time. Appreciate it! 😁
