Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page with hamburger menu

Samuel 260

@5erious5am

Desktop design screenshot for the Loopstudios landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback greatly appreciated

Community feedback

Dušan Lukić 1,660

@dusanlukic404

Posted

Hi Samuel,

Overall, you did great job congrats! You should have a look on your HTML and accessibility issues. There is a lot of issues so make sure to look at every and learn much more about them. Also, I saw that you used a default font-family so make sure to have a look in style-guide and to import proper font-families in your css, or link them in your HTML, button need more padding on top and bottom, and also line-height should not be 2 (too much). I think 1.6 would be perfect.

*important: take a look on your markup and try to use semantic html, like h1, h2, h3 for headings, subheadings etc., button for buttons (not span with class of button), main etc.

Marked as helpful

0

Samuel 260

@5erious5am

Posted

@dusanlukic404 thanks a lot. Really informative. Will work on it.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord