Responsive Landing Page with React, Styled Componenets, Grid, Flexbox

Solution retrospective
This project was fun, but it took me 2 days to complete am I not up to speed? Does my code use the best practices? Also, I am not sure I Would add background color and image on mobile screens?
Any suggestions will be appreciated, this is my first front-end-mentor challenge 😁
Please log in to post a comment
Log in with GitHubCommunity feedback
- @markup-mitchell
don't worry about speed, that happens naturally with practice.
- @iceofice
Hi Krishna Bansal,
Welcome to Frontend Mentor! Well, I am also new here so let's up our skills together! I also finish this challenge in 2 days. I am not really familiar with React but here are my feedbacks,
-
Add a default value for the timeframe, you can set 1 of them to be active so there won't be any 0 value there,
{state === "" ? timeframe["weekly"]["current"] : timeframe[state]["current"]}
-
Make it responsive! I am not really sure how to do it on React but it will be worth checking out.
-
Remove any unnecessary
console.log()
that is used for debugging.
Great job on finishing this challenge! Keep it up! I really like that animation. It makes me want to learn about animation 😅.
-
- @sunil-sharma-999
I really liked the hover animation!
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord